Add missing tests - Githubissues

dkocich / osm-pt-ngx-leaflet

An online web editor used to edit public transport routes on OpenStreetMap built with Angular, Leaflet and Webpack.

http://osm-pt.herokuapp.com

MIT License

17 stars 6 forks source link

Add missing tests #107

Open dkocich opened 7 years ago

dkocich commented 7 years ago

I should test some key functions (changeset file creation from existing edits) - how to e.g. here https://auth0.com/blog/angular-testing-in-depth-components/ note - on the first try, some leaflet classes (L) were unknown to karma when it tried to setup environment =>

all settings should be set properly in karma conf (typescript compiling, loading and using source maps to show stack traces on errors, fix somehow all missing references in the compiled project)

dkocich commented 6 years ago

Tests were added, we should make sure that

[ ] it is possible to run them all
[ ] they are all passing
[ ] we can generate code coverage
[ ] run tests on CI and coverage appears on GH (add Codecov service or any alternative)
[ ] coverage is accessible from GH page (readme contains badge?)