search

dkorunic / iSMC

Apple SMC CLI tool that can decode and display temperature, fans, battery, power, voltage and current information
GNU General Public License v3.0
122 stars 13 forks source link

c warnings on go get #1

Closed tsatke closed 5 years ago

tsatke commented 5 years ago 
$ go get -v github.com/dkorunic/ismc
github.com/jedib0t/go-pretty (download)
github.com/panotza/gosmc (download)
github.com/sirupsen/logrus (download)
get "golang.org/x/sys/unix": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at //golang.org/x/sys/unix?go-get=1
get "golang.org/x/sys/unix": verifying non-authoritative meta tag
golang.org/x/sys (download)
github.com/spf13/cobra (download)
github.com/spf13/pflag (download)
github.com/jedib0t/go-pretty/vendor/github.com/mailru/easyjson/buffer
github.com/panotza/gosmc
golang.org/x/sys/unix
github.com/jedib0t/go-pretty/vendor/github.com/mattn/go-runewidth
github.com/jedib0t/go-pretty/vendor/github.com/globalsign/mgo/internal/json
github.com/jedib0t/go-pretty/vendor/github.com/asaskevich/govalidator
github.com/jedib0t/go-pretty/vendor/github.com/mailru/easyjson/jlexer
github.com/jedib0t/go-pretty/vendor/github.com/mailru/easyjson/jwriter
github.com/jedib0t/go-pretty/vendor/github.com/go-openapi/errors
github.com/jedib0t/go-pretty/vendor/github.com/mitchellh/mapstructure
github.com/spf13/pflag
github.com/sirupsen/logrus
github.com/jedib0t/go-pretty/vendor/github.com/globalsign/mgo/bson
github.com/spf13/cobra
github.com/jedib0t/go-pretty/vendor/github.com/go-openapi/strfmt
github.com/jedib0t/go-pretty/text
github.com/jedib0t/go-pretty/table
# github.com/panotza/gosmc
smc.c:38:1: warning: 'OSSpinLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libkern/OSSpinLockDeprecated.h:79:17: note: 'OSSpinLock' has been explicitly marked deprecated here
smc.c:132:2: warning: 'OSSpinLockLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libkern/OSSpinLockDeprecated.h:99:9: note: 'OSSpinLockLock' has been explicitly marked deprecated here
smc.c:165:2: warning: 'OSSpinLockUnlock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_unlock() from <os/lock.h> instead [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libkern/OSSpinLockDeprecated.h:105:9: note: 'OSSpinLockUnlock' has been explicitly marked deprecated here
github.com/dkorunic/iSMC/smc
github.com/dkorunic/iSMC/cmd
github.com/dkorunic/ismc

Do the warnings from the C file matter?

dkorunic commented 5 years ago

Hey @TimSatke, that's totally fine. Actually those are coming from panotza/gosmc module and originating from low-level CGO smc.c implementation which is using deprecated code but it will work and can be safely ignored.