dkoudlo / GridImageSearch

Grid Image Search
0 stars 0 forks source link

Please Review Grid Search #1

Open dkoudlo opened 10 years ago

dkoudlo commented 10 years ago

@nesquena

I had infinite scroll working but now it broke because of my request url, I think.

nesquena commented 10 years ago

When you are loading more, don't clear the results...you want to append to them so don't clear here only on the initial search. Clearing means there will never be new items appended to the results list so endless scroll won't work. Try that and when you have endless scroll working, ping me back here. See Problem #2 on here if you have more endless scroll issues. Also make sure your results aren't returning duplicates.

dkoudlo commented 10 years ago

@nesquena The infinite scroll is working. Took a while to find that gvResults.setAdapter(imageAdapter); should be setup after the listeners are created it was causing an unexpected behavior.

nesquena commented 10 years ago

:+1: nice work. A few notes after checking out the code:

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.