search

dkprice / vim-easygrep

Fast and Easy Find and Replace Across Multiple Files
The Unlicense
325 stars 47 forks source link

Always No matches #5

Closed noscript closed 10 years ago

noscript commented 10 years ago

I've been testing the latest from master, I always get Warning: No matches. The problem is in HasFilesThatMatch()

let fileList = split(glob(p), " ")

According to vim docs, glob() return a String separated by new line characters. In 0cef91d92 "\n" was changed to " " that broke it.

Also, I think it's better to make glob() return a list by providing the 3rd argument, no need to do the split and saves CPU!

dkprice commented 10 years ago

Hi, great suggestion! I didn't notice this error because I didn't have g:EasyGrepExtraWarnings set -- I probably should do so. I'll make your suggested fix.