search

dkprice / vim-easygrep

Fast and Easy Find and Replace Across Multiple Files
The Unlicense
325 stars 45 forks source link

Add option to include/exclude binary files #54

Closed jpmv27 closed 8 years ago

jpmv27 commented 8 years ago

This is how I implemented #48, not quite as you suggested, but with a Boolean parameter that indicates whether the tool includes or excludes binary files by default. Please take a look and I will rework as required. Once the code is done to your satisfaction, I'll update the docs.

jpmv27 commented 8 years ago

Thanks. But I'm not sure I understand your comment about sift.

Wouldn't the configuration for sift be similar to that for grep?

'opt_str_binary_switch': '--binary-skip' 'opt_bool_binary_excluded_by_default': '0'

Perhaps I misunderstand something MV

jpmv27 commented 8 years ago

Also, do you want a separate PR for adding the new option to the docs, or just update this one?

dkprice commented 8 years ago

My mistake, you're correct. This works nicely. A separate PR for the docs would be good.