dkprice / vim-easygrep

Fast and Easy Find and Replace Across Multiple Files
The Unlicense
325 stars 47 forks source link

MultiSelect mode doesn't work recursively #65

Closed jpmv27 closed 7 years ago

jpmv27 commented 7 years ago

I am using grep as grepprg

When using TrackExt or User mode, the file patterns are wrapped using opt_str_mapinclusionsexpression (--include)

But when using MultiSelect mode, the file patterns are inserted into the command line without wrapping. As a result, recursive searches don't work properly

Is that intentional or a bug? If it's a bug, I'll try to submit a PR

My proposed fix would be to change IsModeFiltered to

    call s:SanitizeMode()
    return s:IsModeTracked() || s:IsModeUser() || s:IsModeMultipleChoice()
dkprice commented 7 years ago

Thanks for the fix! It has the same spirit as the existing code and as such I think its the right one.