search

dkpro / dkpro-argumentation

DKPro Argumentation is a general framework for argumentation mining
Apache License 2.0
4 stars 3 forks source link

Module naming #2

Closed reckart closed 7 years ago

reckart commented 9 years ago

The project uses the rather longish OSGi-inspired naming that we have used a lot in the past. Several projects are switching to the more Maven-default "dkpro-project-module" scheme, e.g. "dkpro-lab-core". It also make the project better readable on Github.

Also, the groupId can be changed to "org.dkpro.project", e.g. "org.dkpro.lab" if desired.

habernal commented 8 years ago

Depends on #4

reckart commented 8 years ago

I don't think that renaming the modules and artifactId/groupId ni the argumentation project is in any way depending on DKPro Core 1.8.0 (#4). The artifactIds/etc. in DKPro Core will not change for the 1.8.0 release for compatibility reasons. This will only be done for a future 2.0.0 release.

reckart commented 8 years ago

The module folders should be renamed to match the artifactIDs.

habernal commented 8 years ago

What about the package names then? Should all be renamed, e.g., de.tudarmstadt.ukp.dkpro.argumentation.preprocessing.annotation.ArgumentTokenBIOAnnotator -> org.dkpro.argumentation.preprocessing.annotation.ArgumentTokenBIOAnnotator ?

reckart commented 8 years ago

Oh, I didn't notice that these have not been updated yet. The package names should have updated also along with changing the groupId. The groupId should always be a prefix of the packages names.

reckart commented 8 years ago

Mind that if you have custom UIMA types, the XML descriptors also need to be updated for the new package names.

habernal commented 7 years ago

Fixed