dkpro / dkpro-cassis

UIMA CAS processing library written in Python
https://pypi.org/project/dkpro-cassis/
Apache License 2.0
85 stars 22 forks source link

Naming: TypeSystem.create_type but add_feature #173

Closed reckart closed 3 years ago

reckart commented 3 years ago

The naming for creating how typesystem-related entities seems inconsistent. E.g. we have a create_type but then a add_feature method. For consistency, the latter should be renamed to create_feature.

Also, there should be a remark on the Type.add_feature() method that it should not be used (maybe even prefix it with _ and that the TypeSystem.create_feature() method should be used instead.

Best deprecate the old names instead of removing.