dkpro / dkpro-cassis

UIMA CAS processing library written in Python
https://pypi.org/project/dkpro-cassis/
Apache License 2.0
85 stars 22 forks source link

#253 - Do not emit warnings during merge #255

Closed jcklie closed 2 years ago

jcklie commented 2 years ago

We now do not warn when redefining features during merge, as that leads too many warnings, especially when merging very similar type systems.

codecov[bot] commented 2 years ago

Codecov Report

Merging #255 (ff5fddc) into main (339c27b) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   95.43%   95.49%   +0.05%     
==========================================
  Files           5        5              
  Lines        1861     1863       +2     
==========================================
+ Hits         1776     1779       +3     
+ Misses         85       84       -1     
Impacted Files Coverage Δ
cassis/typesystem.py 95.65% <100.00%> (+0.16%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

jcklie commented 2 years ago

We auto generate eq based on features when magically generating the class on the fly.