ukp-svc-jenkins
commented
5 years ago Can one of the admins verify this patch?
Closed alaindesilets closed 5 years ago
ukp-svc-jenkins
commented
5 years ago Can one of the admins verify this patch?
reckart
commented
5 years ago Before preparing a new PR, it's always a good idea to switch back to the branch into which the PR should eventually be merged. So the other PR you did is the better one. I'm closing this one.
alaindesilets
commented
5 years ago Yeah, sorry about that. This is a lot of new concepts to learn for me. I am carefully documenting the steps so hopefully my next commit will not be as painful.
BTW: From the emails you have sent it sounds like this change has been effected in master of dkpro-core, but when I go do this URL, I don't see it. Is that normal?
On Thu, Jul 18, 2019 at 3:59 PM Richard Eckart de Castilho < notifications@github.com> wrote:
Before preparing a new PR, it's always a good idea to switch back to the branch into which the PR should eventually be merged. So the other PR you did is the better one. I'm closing this one.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dkpro/dkpro-core/pull/1397?email_source=notifications&email_token=AAIMA4C3EXAOL3IGDRGJ473QADDRFA5CNFSM4IEZOSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JTSIY#issuecomment-512964899, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIMA4C3S3VSXDEPHYHELOTQADDRFANCNFSM4IEZOSRA .
reckart
commented
5 years ago The PR #1398 has not been merged yet. When it is merged, #1398 goes to the master branch (that is how you set up the PR). Since it is a bugfix, it should normally have been opened against the 1.11.x branch. I'll cherry-pick it back into 1.11.x after the merge. But better open bugfix issues against 1.11.x. Note that the master branch builds against UIMAv3 but no other DKPro code so far builds against UIMAv3. So presently, it would be better even do branches for new features against 1.11.x or 1.12.x which are still using UIMAv2.
Sorry about the confusing situation...
alaindesilets
commented
5 years ago Hum.. I thought you had told me to make bug fixes in 1.11.x, but I see that:
So am I confused and should the bug fixes be done against 1.12.x instead of 1.11.x?
On Thu, Jul 18, 2019 at 4:44 PM Richard Eckart de Castilho < notifications@github.com> wrote:
The PR #1398 https://github.com/dkpro/dkpro-core/pull/1398 has not been merged yet. When it is merged, #1398 https://github.com/dkpro/dkpro-core/pull/1398 goes to the master branch (that is how you set up the PR). Since it is a bugfix, it should normally have been opened against the 1.11.x branch. I'll cherry-pick it back into 1.11.x after the merge. But better open bugfix issues against 1.11.x. Note that the master branch builds against UIMAv3 but no other DKPro code so far builds against UIMAv3. So presently, it would be better even do branches for new features against 1.11.x or 1.12.x which are still using UIMAv2.
Sorry about the confusing situation...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dkpro/dkpro-core/pull/1397?email_source=notifications&email_token=AAIMA4AW5KJ2SJZP55BLW23QADIZ3A5CNFSM4IEZOSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JXJMQ#issuecomment-512980146, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIMA4EZGOH6Y4A4IV5SO7TQADIZ3ANCNFSM4IEZOSRA .
reckart
commented
5 years ago master is at 2.0.0-SNAPSHOT since the 1.11.0 release. The 2.0.x series is for UIMAv3.
Bugfixes should go against 1.11.x so we can easily do a bugfix release of the 1.11.x series.
I just pushed a 1.12.x branch in case we want to add features which should be available to UIMAv2.
reckart
commented
5 years ago At this point...
alaindesilets
commented
5 years ago OK, I see. Thx.
On Thu, Jul 18, 2019 at 4:55 PM Richard Eckart de Castilho < notifications@github.com> wrote:
master is at 2.0.0-SNAPSHOT since the 1.11.0 release. The 2.0.x series is for UIMAv3. Bugfixes should go against 1.11.x so we can easily do a bugfix release of the 1.11.x series. I just pushed a 1.12.x branch in case we want to add features which should be available to UIMAv2.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dkpro/dkpro-core/pull/1397?email_source=notifications&email_token=AAIMA4B32JS5RY2CSNDNSLTQADKFHA5CNFSM4IEZOSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JYIXY#issuecomment-512984159, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIMA4BIAIGEMTXW3BCGVYTQADKFHANCNFSM4IEZOSRA .
alaindesilets
commented
5 years ago Crystal clear, thx.
On Thu, Jul 18, 2019 at 4:58 PM Richard Eckart de Castilho < notifications@github.com> wrote:
At this point...
- if we do a new feature release for UIMAv2, it would be DKPro Core 1.12.0.
- if we do a bugfix release for UIMAv2, it will be DKPro Core 1.11.1
- the upcoming feature release for UIMAv3 is DKPro Core 2.0.0
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dkpro/dkpro-core/pull/1397?email_source=notifications&email_token=AAIMA4FBQXGAI54BQPCVZ3LQADKPNA5CNFSM4IEZOSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JYP3A#issuecomment-512985068, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIMA4GSXN466RHDTF2AEZDQADKPNANCNFSM4IEZOSRA .
This pull request deals with issue #1395: "null pointer exception in StanfordNamedEntityRecognizerTrainer"
I am still green w.r.t. issueing pull requests so I am not sure if I did this right. It seems like the branch of this pull request might be based on the branch from my earlier pull request (#1392) and I suspect that this is not a good idea. If this is wrong, please let me know and any help on how to address it would be appreciated. I have been using git for 4 years now, but I never use remote branches so I am not that familiar with how they work and how to set them up. Thank you for your patience.