dkpro / dkpro-core

Collection of software components for natural language processing (NLP) based on the Apache UIMA framework.
https://dkpro.github.io/dkpro-core
Other
196 stars 67 forks source link

#1395 - Stanford NER trainer raises helpful exception when no data received #1398

Closed alaindesilets closed 5 years ago

alaindesilets commented 5 years ago

This is the same change that I did in my earlier pull request, but I think this one was carried out in a branch that does not depend on any other changes I made. You may prefer to pull my changes from this branch instead.

Again, sorry for doing this twice. I am still learning how to use git pull requests and branches.

ukp-svc-jenkins commented 5 years ago

Can one of the admins verify this patch?

reckart commented 5 years ago

Jenkins, can you test this please?

reckart commented 5 years ago

@alaindesilets I have slightly changed the exception such that we actually throw the checked exception instead of an unexpected unchecked exception. I'll squash the PR when merging which means that our individual commits are no longer visible (which I usually prefer), but it saves me from having to rewrite your commit messages which don't correspond to the usual format (end of page).

ukp-svc-jenkins commented 5 years ago

69% (-4.51%) vs master 73%

reckart commented 5 years ago

Jenkins, can you test this please?

ukp-svc-jenkins commented 5 years ago

69% (-4.55%) vs master 73%