search

dkpro / dkpro-core

Collection of software components for natural language processing (NLP) based on the Apache UIMA framework.
https://dkpro.github.io/dkpro-core
Other
195 stars 67 forks source link

ApplyChangesAnnotator: make source and target view configurable #1458

Closed ramonziai closed 4 years ago

ramonziai commented 4 years ago

There are scenarios where one would like to name the source and/or target view dynamically, for example when the name must be constructed at runtime. This change adds UIMAfit parameters for the two view names.

ukp-svc-jenkins commented 4 years ago

Can one of the admins verify this patch?

reckart commented 4 years ago

Normally this would be done via view mapping at the pipeline level - not in the component. I would need to look around for an illustrative example if you like.

ramonziai commented 4 years ago

Ah I see, thanks. So that would be something like AggregateBuilder.add(applyChangesDesc, ApplyChangesAnnotator.VIEW_SOURCE, "mySource", ApplyChangesAnnotator.VIEW_TARGET, "myTarget")? If yes, feel free to close this pull request :-)

reckart commented 4 years ago

Right. When I first implemented the components I used this to cascade several mappers and backmappers in a pipeline.

ramonziai commented 4 years ago

Ok, I'll try that then! Closing PR.