dkpro / dkpro-core

Collection of software components for natural language processing (NLP) based on the Apache UIMA framework.
https://dkpro.github.io/dkpro-core
Other
196 stars 67 forks source link

CRFClassifier#getClassifier input stream should be buffered #1478

Closed StefWin closed 1 year ago

StefWin commented 4 years ago

Hi, I've found a minor bug inside the CoreNlpNamedEntityRecognizerModelProvider when loading an CRFClassifier the InputStream is not buffered, but it should be as the jdoc states:

... This method does not buffer the InputStream, so you should have buffered it before calling this method.

reckart commented 4 years ago

Did you try buffering it and did you observer any improvement by doing so?