search

dkpro / dkpro-lsr

Unified API for standard lexical-semantic resources.
https://dkpro.github.io/dkpro-lsr
Other
8 stars 1 forks source link

Migrate from JWNL to extJWNL 1.9 #4

Closed logological closed 9 years ago

logological commented 9 years ago

DKPro LSR currently uses the ancient, buggy, and unmaintained JWNL. Most modern NLP applications have moved to extJWNL, which is maintained. Unfortunately, using both JWNL and extJWNL in the same project can lead to errors, so this limits the usability of DKPro LSR in other projects.

It would be nice if DKPro LSR were rewritten to use the latest version of extJWNL (1.9).

I've done a local rewrite myself. The only classes which I was unable to migrate were de.tudarmstadt.ukp.dkpro.lexsemresource.wordnet.util.UkpFileManagerImpl and de.tudarmstadt.ukp.dkpro.lexsemresource.wordnet.util.UkpRandomAccessDictionaryFile. I have no idea what these are for; they have no meaningful documentation and they're not referenced anywhere else in DKPro LSR, including in any unit tests. Would it be OK if I simply removed these two classes?

reckart commented 9 years ago

Sounds like attempts to load the data from alternative places. I don't think these are of relevance anymore since extJWNL supports loading the resources from JARs (Maven dependencies).

zesch commented 9 years ago

I think @reckart is right. These files were special implementations of the classes references in the JWNL configuration file. If we switch to extJWNL anyway, we will not need them anymore.

logological commented 9 years ago

Duplicate of Issue #2.