Closed mromanello closed 6 years ago
@mromanello WOW, great!
I have updated the commit messaged according to our conventions to include the issue number and force-pushed them into the PR.
Btw. when you create a PR, it is highly recommendable to first create a feature branch in your repo (e.g. feature/4-proper-python-package
), then make the changes in that branch and create a PR from that branch. This avoids potential serious confusion with the master branch in your clone and in the main repo diverging.
Could you provide us with a contributors license agreement? See https://dkpro.github.io/contributing/
thanks @reckart ! I haven't contributed to many OS projects in the past, so I'm still learning how to properly do so ;-)
as for the contributor license agreement: is it ok the individual one? I'll do so right away.
ICLA is sufficient for us. We always consider contributions to be from the individual. Whether you need to discuss such contributions with superiors or employees is something we cannot know. The purpose of the CCLA is to have an additional layer of confirmation for contributors who do their contributions as part of a employment/contract. However, since we cannot know the circumstances of the contribution, the CCLA is optional for us. In the ICLA, you assert that you are in a position to make the contribution - that is enough for us.
great! my signed ICLA is on its way towards the email address indicated in the license
Following what sketched in issue 4, I have:
tox
which run the tests under different python versionsI wasn't able to get it pass the tests under py27.