dkpro / dkpro-similarity

Word and text similarity measures
https://dkpro.github.io/dkpro-similarity
Other
53 stars 22 forks source link

Maven central #28

Closed nicolaierbs closed 8 years ago

nicolaierbs commented 9 years ago

Original issue 28 created by dkpro on 2014-05-02T13:51:55.000Z:

Hi,

is there any plan or timetable about pushing the dkpro-similarity-asl library(s) to Maven Central. I have to use this lib in an Maven central compliant framework and I need a compliant enviroment

Best regards Thomas

nicolaierbs commented 9 years ago

Comment #1 originally posted by dkpro on 2014-05-02T14:58:53.000Z:

It is definitely planned, but there is no timetable yet. This project depends on so many other projects not yet on maven central that I cannot promise that it will be anytime soon.

reckart commented 8 years ago

How much of similarity would be "lost" if we only released the things that have no problematic dependencies?

zesch commented 8 years ago

Does "problematic" include third party uploads? If yes, we would lose 3/4 of similarity (conservative estimate).

reckart commented 8 years ago

Yea, I though mainly about third-party uploads actually. Are there other kinds of problems?

zesch commented 8 years ago

IIRC DKPro LSR is also not on maven central yet.

areese commented 8 years ago

Is there a dependency tree that can be looked at as to what is preventing it from going to maven central?

@nschimme and I are interested in pulling from maven central: So I don't have to mirror it and so we don't end up taking your artifactory out on accident by pushing way too much traffic.

reckart commented 8 years ago

You can use Eclipse or the Maven dependency plugin to generate a tree. I don't think though that there is an option to tell you from which particular repository a dependency was pulled.

Mind that Maven Central could in theory also fail or be temporary unavailable. I would always recommend to run a mirroring proxy repository under your control if you heavily rely on Maven.

https://maven.apache.org/plugins/maven-dependency-plugin/

reckart commented 8 years ago

Sorry, actually this seems to be what you are looking for ;)

https://maven.apache.org/plugins/maven-dependency-plugin/list-repositories-mojo.html

areese commented 8 years ago

We mirror central. :) I'm just trying to avoid mirror sprawl, where I have a giant list of mirrors to manage.

What I'm asking is what dependencies prevent you from pushing to central. That's what I'm curious about.

reckart commented 8 years ago

Ok, I just tried the "list-repositories" mojo, but it doesn't say which dependency comes from which repo - it only lists the repos used in a module.

So what you could try without hunting down each dependency individually is:

Might work ;) Cannot try it currently.

areese commented 8 years ago

Thanks I'll work with @nschimme on this and see what we can come up with. I appreciate the effort.

reckart commented 8 years ago

We should also fix the groupId/artifactId before deploying this on a proper repository: #27

torbjornvatn commented 8 years ago

Any ETA on when this could get pushed to Maven Central?

nicolaierbs commented 8 years ago

@torbjornvatn: I plan to work on the project after christmas, but it will be hard to estimate when we'll be finished.

nicolaierbs commented 8 years ago

Preparation of release started. Opened issue for creating project at https://issues.sonatype.org/browse/OSSRH-19698

nicolaierbs commented 8 years ago

I analyzed the dependencies in DKPro Similarity and found only few, which are not on Maven Central.

I would propose to release everything left to Maven Central. All modules using DKPro LSR will not be released and reintegrated after DKPro LSR has been replaced.

reckart commented 8 years ago

Hum, were the experiments not an essential part of DKPro Similarity? Why not exclude them from deployment instead of completely deleting them? Likewise for the modules that use LSR.

nicolaierbs commented 8 years ago

I agree. We can keep the deleted modules and exclude them from the release. Any other objections, or can I continue with the release to Maven Central?

reckart commented 8 years ago

Do you have license checking in place for ASL and GPL? Are NOTICE.txt files in place that explain where third party code and/or resources come from (if any)? If you plan to release, I suggest you stop after you have staged the artifacts and ask us to review the staged artifacts before you promote them to Maven Central.

nicolaierbs commented 8 years ago

Richard, do you have any recommendation how to check licenses?

reckart commented 8 years ago

You can copy the respective configurations from DKPro Core:

Place these in the corresponding ASL/GPL aggregator modules in DKPro Similarity.

The GPL check requires each module to contain a .license-header.txt file with the respective license text. Cf. such files in DKPro Core.

nicolaierbs commented 8 years ago

Does anyone know whether we can include a dependency with the University of Illinois/NCSA Open Source License (NCSA) in an ASL module? According to https://opensource.org/licenses/NCSA and http://directory.fsf.org/wiki/License:IllinoisNCSA it is non-copyleft and allows commercial use. It is definitely compatible to GPL, but I don't want to move it to GPL without any need.

reckart commented 8 years ago

Do you have a link to the software (not the license)?

NCSA is listed at ASF under similar to ALv2 (http://www.apache.org/legal/resolved.html#category-a) - so it's totally fine for us.

nicolaierbs commented 8 years ago

Sure. They recently moved to GitHub: https://github.com/TeamCohen/secondstring/

nicolaierbs commented 8 years ago

I just added the necessary plugins to the parent pom. Is there anything I should check, or can I go ahead and do the release?

nicolaierbs commented 8 years ago

Uploaded 3rd party dependencies to Maven Central (http://search.maven.org/#artifactdetails%7Ccom.wcohen%7Ccom.wcohen.secondstring%7C0.1%7Cjar)

nicolaierbs commented 8 years ago

DKPro Similarity 2.2.0 has been successfully released! Could you please review the artifacts (http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.dkpro.similarity%22) and comment if there are any problems.

daxenberger commented 8 years ago

great news! :)

nicolaierbs commented 8 years ago

Closing this issue. Please re-open if there are any difficulties using the version from Maven Central