search

dkpro / dkpro-similarity

Word and text similarity measures
https://dkpro.github.io/dkpro-similarity
Other
53 stars 22 forks source link

Method getSimilarity(string1, string2) in GreedyStringTiling, #58

Closed albarron closed 7 years ago

albarron commented 7 years ago

Method getSimilarity(string1, string2) in

results in NaN if string1 is empty (note that in cases where string2 is the empty one, the result is 0). I added an if to the methods in the corresponding classes: if string1 is empty, return 0.

reckart commented 7 years ago

I do not think we have a CLA for albarron - we cannot merge non-trivial changes without a CLA.

reckart commented 7 years ago

@nicolaierbs @albarron could you please review the contribution guidelines (http://dkpro.github.io/contributing/) and submit a CLA in order to have keep this change merged?

albarron commented 7 years ago

I understand this protocol, which includes signing an agreement, is for major contributions. In this case, it is an “if" with a “return 0;” in four classes. Still, I asked in my institution and for them to sign such a letter (if they do) could take weeks (bureaucracy is not always efficient).

If you consider my editions make sense, it would be great if you can accept the pull request as it is. Otherwise, I could raise an issue with the problem I found and I could tell you where and what to change to address it.

On Dec 19, 2016, at 13:11, Richard Eckart de Castilho notifications@github.com wrote:

@nicolaierbs https://github.com/nicolaierbs @albarron https://github.com/albarron could you please review the contribution guidelines (http://dkpro.github.io/contributing/ http://dkpro.github.io/contributing/) and submit a CLA in order to have keep this change merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dkpro/dkpro-similarity/pull/58#issuecomment-267927642, or mute the thread https://github.com/notifications/unsubscribe-auth/AFH9O0YEtqRtZUisSWahbZpo-MrRRs7lks5rJlhNgaJpZM4LQi9Q.

reckart commented 7 years ago

@albarron maybe you can check back with your responsible superior whether the contribution is ok. If you are confident after that that it is ok for you to make the contribution, then you could file the ICLA and submit the CCLA at a later time. In the ICLA, you declare that you can make the contribution. The CCLA is a second "bright line" to ensure that your employer is also informed and gave their consent - however, it is more a document to keep you at peace then to keep us at peace.