search

dkpro / dkpro-tc

UIMA-based text classification framework built on top of DKPro Core and DKPro Lab.
https://dkpro.github.io/dkpro-tc/
Other
34 stars 19 forks source link

WordShapeClassifer is GNU license #453

Closed Horsmann closed 6 years ago

Horsmann commented 6 years ago

We seem to have a license issue in the features project.

This class: https://github.com/dkpro/dkpro-tc/blob/master/dkpro-tc-features/src/main/java/org/dkpro/tc/features/window/WordShapeClassifier.java is copied from Stanford: https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/process/WordShapeClassifier.java, which is GNU

@reckart This probably cannot be resolved without making the feature project GNU, right? @betoboullosa You added the classes originally, do you still work with them?

reckart commented 6 years ago

The WordShape code from CoreNLP/StanfordNLP cannot be used in our code without making the affected code GPL. It would have to be moved to a separate GPLed module.

Or you'd have to re-implement the code, optimally using a "clean room" approach in which you do actually not look at the original GPLed code.

Or you could ask Manning et al. whether they would consider placing the code under a non-GPL license, e.g. Apache, BSD, MIT etc.

Horsmann commented 6 years ago

I expected that much :(. I think this class has been added before the last release, which means this is already contained in the 0.9.0 release. I would delete the classes for now. They can be fished-out the Git if they are needed by someone.