search

dkpro / dkpro-tc

UIMA-based text classification framework built on top of DKPro Core and DKPro Lab.
https://dkpro.github.io/dkpro-tc/
Other
34 stars 19 forks source link

Line-breaks should use System.lineSeparator() #462

Closed Horsmann closed 6 years ago

Horsmann commented 6 years ago

Line-breaks are often hard-coded as '\n'. It would be more clean to use System.lineSeparator() which sets them correctly for Windows i.e. \r\n

reckart commented 6 years ago

I usually do not do this. It makes the code annoyingly unreadable and hardly contributes anything.

reckart commented 6 years ago

In fact, if I notice any code in my projects which does this, I usually change it to use simply \n.

zesch commented 6 years ago

It also might break compatibility when moving a file generated by TC between *nix and Windows machines.

Horsmann commented 6 years ago

^^ ok, I am convinced.