search

dkpro / dkpro-uby

Framework for creating and accessing UBY resources – sense-linked lexical resources in standard UBY-LMF format
https://dkpro.github.io/dkpro-uby
Other
22 stars 3 forks source link

Why UbyInvalidArgumentException instead of a simple InvalidArgumentException? #91

Closed judithek closed 9 years ago

judithek commented 9 years ago 
The constructor of Uby throws an UbyInvalidArgumentException. Why not a standard InvalidArgumentException
or even simply a NullPointerException?

Original issue reported on code.google.com by richard.eckart on 2014-06-21 14:13:00

judithek commented 9 years ago 
there is no special reason - this was never discussed in the group

so your suggestion might be an improvement

Original issue reported on code.google.com by eckle.kohler on 2014-06-21 16:23:41

judithek commented 9 years ago 
(No text was entered with this change)

Original issue reported on code.google.com by eckle.kohler on 2014-07-18 07:12:41

judithek commented 9 years ago 
Has this already been discussed? Are there any objections to me making such a change
(given some spare time)?

Original issue reported on code.google.com by richard.eckart on 2014-07-19 12:31:22

judithek commented 9 years ago 
>> Has this already been discussed? 

no, will put it on the meeting agenda for next week

>> Are there any objections to me making such a change (given some spare time)?

I do not have any objections.

But since Michael coded the UbyInvalidArgumentException we should discuss it.

Original issue reported on code.google.com by eckle.kohler on 2014-07-19 15:12:02

judithek commented 9 years ago 
This issue was closed by revision r621.

Original issue reported on code.google.com by eckle.kohler on 2014-07-31 15:59:14