dkrasner / Simpletalk

Apache License 2.0
53 stars 3 forks source link

adding missing skip of editor-open prop on image/world serialization #116

Closed dkrasner closed 2 years ago

dkrasner commented 2 years ago

Main Points

Due to race conditions (editor tries to center the corresponding part which might not have come into view on deserialization), we don't preserve editor prop state. I had added this to Part.serialize() but forgot to do so for Image and WorldStack.

This was a bit of a pain to debug b/c deserializing the halo was open not the editor: the editor-open prop on Image was causing halo-open to be set to true, but the editor itself was not open. Potentially we want to decouple halo and editor but visually it does make sense to have the former open when the latter is...