search

dkrichards86 / downtimer

Downtimer is a browser based productivity timer and wellness app.
https://downtimer.io
MIT License
0 stars 0 forks source link

Menu button click target #4

Closed dkrichards86 closed 5 years ago

dkrichards86 commented 5 years ago

What is the current behavior? Menu button has a temperamental click target. One some occasions, one click will open the menu. On others, it takes multiple clicks.

If the current behavior is a bug, please provide the steps to reproduce Click on the menu button (hamburger) and note the opening/closing of the sidebar..

What is the expected behavior? One click opens the menu.

Other information I suspect this is due to a click action being placed on the icon, not the button itself. This functionality is straight from Vuetify.

dkrichards86 commented 5 years ago

Looks like this is attributable to our sidebar props pattern. The clickaway handler doesn't bubble to the wrapper, so the button gets out of sync with the sidebar.

We can resolve this by either a) moving sidebar to the wrapper component, or b) broadcasting the clickaway event so wrapper is aware of the sidebar's state.