search

dkriegls / itmd-362-spring2018

For ITMD 361 class, Spring semester 2018, at Illinois Institute of Technology
1 stars 36 forks source link

Did not pass the W3C CSS Validation #2

Open ghost opened 6 years ago

ghost commented 6 years ago

https://github.com/dkriegls/itmd-362-spring2018/blob/e683b3134957e1e4b0408bacb9a32f8a16643d2a/css/screen.css#L24

html: Property text-size-adjust doesn't exist : 100%

As you said "Work which fails HTML or CSS validation will receive a 50% point reduction!", HOW ABOUT YOU?

Your mad student again,

vkoves commented 6 years ago

@dobetterdude - This should be combined with #1, which it shares a title with. Could you make a fork and open a PR to resolve this issue, since it seems to be bothering you?

ghost commented 6 years ago

@vkoves It's not my job to make the course website meet my instructor's own requirement.

dkriegls commented 6 years ago

@dobetterdude it is not your job. It is however your job to listen to the teacher when they explain the difference between a validation warning and a validation failure.

ghost commented 6 years ago

@dkriegls Please explain why there are two id="name" present at itmd-362-spring2018/demos/week6/box-sizing/box-sizing.html.

What's the difference between class and id?

dkriegls commented 6 years ago

@dobetterdude thank you for pointing out the error. Here is the MDN documentation on selectors. It explains the difference between ID and Class selectors.

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors