search

dkriegner / xrayutilities

xrayutilities - a package with useful scripts for X-ray diffraction physicists
http://xrayutilities.sourceforge.io
GNU General Public License v2.0
83 stars 29 forks source link

_area_detector_calib_fit is an empty function? #156

Closed EricShmeric closed 1 year ago

EricShmeric commented 1 year ago

I'm not a very experienced python programmer, so I might be missing something silly here, but it appears that the _area_detector_calib_fit function within sample_align.py was never implemented? I just see comments explaining what the parameters and returns should be.

This appears to be the workhorse function for the area_detector_calib function which has an example dedicated to it. I don't understand how this example is supposed to work without the fit function? When I try to run the program just crashes on the line because the function returns none.

Any guidance would be much appreciated!

dkriegner commented 1 year ago

I am not sure what you refer to, there is clearly hundreds of code lines in this function (which are in place since many years): https://github.com/dkriegner/xrayutilities/blob/611fbe78f882f14f13872ec0a93f5d7dab89c15b/lib/xrayutilities/analysis/sample_align.py#L830-L1231

If you do not have them in your version than I think something went wrong with your download/installation. What version are you using, and how did you install it? Where are you looking for the code?

EricShmeric commented 1 year ago

Ah yes, I indeed did something silly. I see the code now. Sorry for the dumb question and thank you for the quick response!