setup.py imports numpy (pip install error)

[ceeli]

Hello I've noticed on a fresh virtual machine that you can't install xrayutilities without installing numpy manually first. That is because numpy is imported in setup.py which must be imported to fetch the dependencies in the first place. I looked at it and it seems that numpy isn't used in setup.py. I think just removing the import should solve the issue.

[dkriegner]

Unfortunately numpy is needed in setup.py. it can't be removed. Using pip numpy should be fetched before setup.py is imported.

Can you explain the commands you used?

I maybe need to change the documentation to only showcase the use of pip.

On Thu, 13 Feb 2020, 13:12 Markus Hovorka, notifications@github.com wrote:

Hello I've noticed on a fresh virtual machine that you can't install xrayutilities without installing numpy manually first. That is because numpy is imported in setup.py which must be imported to fetch the dependencies in the first place. I looked at it and it seems that numpy isn't used in setup.py. I think just removing the import should solve the issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dkriegner/xrayutilities/issues/95?email_source=notifications&email_token=ACKZJFM6WA2WTVWH62NFKSTRCU2K3A5CNFSM4KURGDIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INHYH2Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKZJFPUM25SCFJNZJE7WFTRCU2K3ANCNFSM4KURGDIA .

[ceeli]

Oh I didn't notice that you need the header files of numpy, sorry.

I never had any troubles actually installing the package, I just noticed the sub optimal behavior when numpy is not installed, but I guess there is no good solution to that. Thanks for the fast answer though :)

[dkriegner]

reopening until documentation is fixed to show only pip usage (or add an appropriate note for the user of setup.py)