dkriegner / xrayutilities

xrayutilities - a package with useful scripts for X-ray diffraction physicists
http://xrayutilities.sourceforge.io
GNU General Public License v2.0
83 stars 29 forks source link

explore Crystal unit cell transformations #99

Closed dkriegner closed 4 years ago

dkriegner commented 4 years ago

This developed out of issue #97

This likely needs also to allow for more flexible unit cell (Base) definitions.

dkriegner commented 4 years ago

the first two points are effectively implemented in 03073e38ce20f42143c09d6f93cf28a976660256

dkriegner commented 4 years ago

The material definition from generators seems to not fit at all to the current way SGLattice is implemented, which heavily relies on knowing the space group and related tabulated properties.

While all this could be re-implemented only using the generators it would be less efficient. If this is a feature somebody needs and he/she can explain why the benefits outweigh the disadvantages a new issue should be reported and one might add this functionality.

Likely one would need to derive a new class from SGLattice which re-implements the problematic methods. The derived class could then serve equally in the definition of a Crystal object.