Closed SB2318 closed 1 week ago
dkrivoruchko
commented
1 week ago Great job! Will check later in details.
Small comment: strings that have translatable="false" like
<string name="app_name" translatable="false">ScreenStream</string>
should NOT be translated. Please update PR.
SB2318
commented
1 week ago Okay, Thanks for your feedback. 😊 And Looking forward for your response.
On Thu, Jul 4, 2024, 5:19 PM Dmytro Kryvoruchko @.***> wrote:
Great job! Will check later in details.
Small comment: strings that have translatable="false" like
ScreenStream should NOT be translated. Please update PR.
— Reply to this email directly, view it on GitHub https://github.com/dkrivoruchko/ScreenStream/pull/261#issuecomment-2208770910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU4OIYBBCEPKNO52PVS3DGLZKUZERAVCNFSM6AAAAABKLL76JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYG43TAOJRGA . You are receiving this because you authored the thread.Message ID: @.***>
dkrivoruchko
commented
1 week ago Thank you for your efforts.
I merged it and fixed small issues.
Also found some missing translations for string-array values like:
https://github.com/dkrivoruchko/ScreenStream/blob/1a9e69a3195472b485f8789177e293e555fe12be/mjpeg/src/main/res/values/strings.xml#L71
or
https://github.com/dkrivoruchko/ScreenStream/blob/1a9e69a3195472b485f8789177e293e555fe12be/app/src/main/res/values/strings.xml#L49
Will be nice to have them translated also.
dkrivoruchko
commented
1 week ago Btw, there is a server repo for WebRTC mode. Fill free to help with them also https://github.com/dkrivoruchko/ScreenStreamWeb/tree/main/src/client/static/lang
SB2318
commented
1 week ago Btw, there is a server repo for WebRTC mode. Fill free to help with them also https://github.com/dkrivoruchko/ScreenStreamWeb/tree/main/src/client/static/lang
Sure! 🎉 Happy to contribute! 😊 And thanks for considering the previous contribution. 👍
Hello @dkrivoruchko,
I hope you are doing well!
As I have shown my interest in the locale addition for your application, I have submitted a pull request (PR) that adds support for seven different locales to each submodule of your application.
Please review my PR and provide any feedback or modifications that you think are necessary. I'm looking forward to your input to make the application accessible to a wider audience.
Thank you!
Fixes #258