search

dkrprasetya / simple-firebase-unity

Firebase Realtime-Database's REST API Wrapper for Unity in C#
143 stars 40 forks source link

Incorrect method description on first overload of Firebase.SetValue #25

Closed lachlansleight closed 3 years ago

lachlansleight commented 5 years ago

Should read "Calls OnSetSuccess on success", but currently reads "Calls OnUpdateSuccess on success". Also reads "Calls OnUpdateFailed" rather than "Calls OnSetFailed".

Super easy to fix and is pretty annoying until a hypothetical dev decides to start trying random event handlers in desperation ;)

Specifically, line 467 and 468 of file

https://github.com/dkrprasetya/simple-firebase-unity/blob/master/Assets/SimpleFirebaseUnity/Scripts/Firebase.cs

dkrprasetya commented 3 years ago

Hey, I haven't checked this for a while. You're right, this is super easy to fix and I've pushed the fix. Thanks for catching this.

lachlansleight commented 3 years ago

No worries - but you might also want to update line 466 while you're at it - it still reads "Calls OnUpdateSuccess" etc :P