search

dkrprasetya / simple-firebase-unity

Firebase Realtime-Database's REST API Wrapper for Unity in C#
143 stars 40 forks source link

Failed Queue Pushes are still cleared from queue #7

Closed ZenithCode closed 6 years ago

ZenithCode commented 7 years ago

Hi,

I've been testing this plugin but I found an issue with the queue.

If you lost internet and the Push failed, I get an error saying that Firebase is unable to resolve host but even though this happens, the message is still cleared from the queue.

Shouldn't it be kept it the queue until it is successfully sent (or app is quit)? Regards,

dkrprasetya commented 7 years ago

Ah, yes. I haven't considered the offline persistence or whatsoever when I implemented that one. The current FirebaseQueue was only intended to provide a simple implementation to make the requests sent in order rather than being sent asynchronously at the same time.

I agree it would be better to have that option. I will see what I can modify from my code to make it behave as the expected later this week.

Cheers

ZenithCode commented 7 years ago

Thanks - that would be helpful.

dkrprasetya commented 6 years ago

Thank you for your suggestion. I have included this logic on 4f7f798.