dktr0 / estuary

Platform for collaboration and learning through live coding
GNU General Public License v3.0
165 stars 26 forks source link

Terminal parser working #160

Closed luisnavarrodelangel closed 3 years ago

luisnavarrodelangel commented 3 years ago

Hi David,

This is an update of the pull request from Dec 2020, which includes the terminal parser working for both chat comments and commands starting with '!'. The default view has changed to def to avoid parser errors, but !presetview and !publishview, accept literal text now, so we can do !presetview "twocolumns" and !publishview "default" or !publishview "def". The command !publisdefaultview is also available.

I wasn't able to display the line and character numbers when the terminal parser fails. The errors it currently displays are the following:

-if by accident only an exclamation point (!) given then it reports: Error: "Parse error: EOF" -if the identifier is missing (e.g. if only given !preseteview ) then it reports Error: "" --if the command is wrong or incomplete then it reports Error: ""

Best, Luis