dktr0 / estuary

Platform for collaboration and learning through live coding
GNU General Public License v3.0
165 stars 26 forks source link

loopAt is buffering a lot of whitespace at the end of a sample #181

Open cleary opened 3 years ago

cleary commented 3 years ago

Hi David, Testing out some of my own breaks samples tonight, and I've discovered that loopAt does not work as expected in estuary

It's like it's reading the sample as significantly longer than it is, jamming the sample into the early part of the loop, then leaving whitespace to the end.

Here's a little video comparison between the same samples in tidalcycles proper, and estuary - cps is set to 0.5 in both cases :

The upload seems to be having some issues playing back on my end, here's a youtube link:

https://youtu.be/jjCKxIkzk6w

https://user-images.githubusercontent.com/2577966/133256453-4f4a5205-12ac-47cc-a514-edc73bf0b309.mp4

dktr0 commented 3 years ago

Thanks for noting this issue! Looking at the TidalCycles documentation for loopAt: https://userbase.tidalcycles.org/loopAt

one thing that jumps out at me right away is that I don't think WebDirt: https://github.com/dktr0/WebDirt

implements "c" for the "unit" parameter, yet. So, as with so many of these Tidal/MiniTidal discrepancies, looks like another case of some missing lower level functionality in WebDirt.