dkubb / axiom

Simplifies querying of structured data using relational algebra
https://github.com/dkubb/axiom
MIT License
459 stars 22 forks source link

Add equal value spec for unrelated objects #22

Closed mbj closed 11 years ago

mbj commented 11 years ago

We fixed a similar issue on equalizer already. IHMO we should use equalizer also on veritas and this spec is to highlight the problem.

https://github.com/dkubb/equalizer/pull/7

I do not expect this is gets merged, only opening to start the discussion.

header = Veritas::Relation::Header.coerce([[:foo, String]])
relation = Veritas::Relation.new(header, [])
relation == Object.new # blows up and IMHO should return false
dkubb commented 11 years ago

This is resolved in https://github.com/dkubb/axiom/commit/89a5207785f3acf5d95748724b0742ae53a8dc00

mbj commented 11 years ago

@dkubb nice! thx.