search

dkuppitz / rexpro-client

RexPro Client for .NET
Other
10 stars 4 forks source link

Removed hard-coded values for graphName and graphObjName #7

Closed rossmills99 closed 10 years ago

rossmills99 commented 10 years ago

The graphName and graphObjName fields on the GraphSettings object are currently ignored because of the values set in the ScriptRequestMetaData constructor. Removing them allows arbitrary named graphs from the Rexster configuration to be used (instead of just those named "graph").

I could have added a test of the RexProClient constructor with a GraphSettings object, however I wasn't sure about introducing a dependency on a given graph being named in the Rexster configuration.

dkuppitz commented 10 years ago

The default settings were removed in the v1 imlementation. See: https://github.com/dkuppitz/rexpro-client/blob/rexpro-v1/RexProClient/Messages/ScriptRequestMetaData.cs

rossmills99 commented 10 years ago

Thanks for the heads up about v1 implementation. Can we put the v1 implementation onto NuGet? I think I only get the older version from there.

dkuppitz commented 10 years ago

Hi Ross,

the current RexPro Client version on NuGet is 2.0.5066.40973. This one supports the v1 implementation.

https://www.nuget.org/packages/RexProClient/

Cheers, Daniel