search

dl1ycf / pihpsdr

Raspberry Pi standalone code for HPSDR (old and new Ethernet protocol)
GNU General Public License v3.0
41 stars 21 forks source link

Noise: fix build issue #14

Closed ra1nb0w closed 1 year ago

ra1nb0w commented 1 year ago

remain a linking issue that I need to investigate since I can't find why it doesn't find the symbol. Tested on Linux.

ra1nb0w commented 1 year ago

The linking issue was due to the need of vu3rdd's rnnoise so nothing related to pihpsdr. Regarding Makefile: you need pkg-config of libspecbleach and rnnoise because it is not linked on vu3rdd's rnnoise .

dl1ycf commented 1 year ago

Dear David,

I have applied your first correction manually. For the second, my idea was that if there is a locally modified version of WDSP, then when creating the shared library (dylib) the link references are embedded there. E.g. there is no fftw linking in pihpsdr although WDSP is using it. So can you explain why a library not used by pihpsdr directly need be included in the Makefile?

ra1nb0w commented 1 year ago

first, thank you very much for your hard work!

The line ifeq ($(EXTENDED_NOISE_REDUCTION_OPTIONS), EXTNR) is to make the option equal to the others. Regarding the linking of libspecbleach and rnnoise, they are needed because upstream vu3rdd's wdsp are not linking it correctly and this is a temporary fix. I would like to open an issue at vu3rdd repository but it seems not in sync with your dsp code and I am not sure it is still maintained. It is a way to use those features without headache meanwhile the wdsp fork is up to date and fixed.

dl1ycf commented 1 year ago

I am in contact with vu3rdd, and he asked me where to find the latest WDSP code. So there is hope the WDSP there will be updated. I already exchanged comments on how this is internally included in WDSP. I think the proper way is not to modify piHPSDR but download the vu3rdd wdsp if you want to use it and modify the makefile there. Note vu3rdd also had to modify the pihpsdr makefile as to link with fftw3, and I think for the same reason.

Am 21.07.2023 um 19:24 schrieb ra1nb0w @.***>:

first, thank you very much for your hard work! The line ifeq ($(EXTENDED_NOISE_REDUCTION_OPTIONS), EXTNR) is to make the option equal to the others. Regarding the linking of libspecbleach and rnnoise, they are needed because upstream vu3rdd's wdsp are not linking it correctly and this is a temporary fix. I would like to open an issue at vu3rdd repository but it seems not in sync with your dsp code and I am not sure it is still maintained. It is a way to use those features without headache meanwhile the wdsp fork is up to date and fixed. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

ra1nb0w commented 1 year ago

Thank you. vu3rdd should modify his Makefile and fix the linking issue. I close this PR.