Is it possible to implement the CESSB switch? It doesn't have to be now

dl1ycf / pihpsdr

Raspberry Pi standalone code for HPSDR (old and new Ethernet protocol)

GNU General Public License v3.0

41 stars 21 forks source link

Is it possible to implement the CESSB switch? It doesn't have to be now #29

Closed qwgsdy closed 3 months ago

qwgsdy commented 4 months ago

The WDSP manual defines an on/off software switch for the CESSB overshoot control through the command 'void SetTXAosctrlRun (int channel, int run)'. In Pihpsdr this switch is set inactive. Add it with default 'off' as a checkbox in the tx menu that is operable when the other conditions are met, compressor active, and linear phase filter chosen.

dl1ycf commented 3 months ago

I think most things should be automatic, not worrying the end user with too many options. If this control is automatically set "on" whenever compression is on and the TX filter is linear phase, would this be an improvement?

qwgsdy commented 3 months ago

It would definitely be an improvement. I would really like to see this feature.

dl1ycf commented 3 months ago

What I have done now:

allow only "linear phase" for the TX filter
activate/deactivate CESSB overshoot correction whenever TX compression is activated/deactivated

The advantage of this is:

no additional GUI elements that only confuse end users
users cannot make "illegal" settings