dl1ycf / pihpsdr

Raspberry Pi standalone code for HPSDR (old and new Ethernet protocol)
GNU General Public License v3.0
41 stars 21 forks source link

Mute not working #39

Closed mcogoni closed 2 weeks ago

mcogoni commented 1 month ago

Hi Christoph, I wasn't able to use the mute function: it does nothing at all.

marco / IS0KYB

dl1ycf commented 2 weeks ago

The mute function is intended to mute the audio that goes to the radio. Headphones connected to sound cards that are connected directly to the computer will not be affected.

So, be more specific in your problem report, perhaps piHPDSDR behaves according to the manual, but not according to your expectations?

mcogoni commented 2 weeks ago

Uhm, not at all. MUTE: Toggles the ,,mute” state of the active receiver. If a receiver is muted, it produces zero-amplitude audio output.

Maybe you're referring to this: Mute Audio to Radio. If checked, the audio in the HPSDR data stream from this receiver is muted. This has only an effect for Protocol-1 and Protocol-2 (not for SoapySDR), and only affects headphones/speakers connected to the radio. Local audio is not affected. The main use of this checkbox is to mute a radio-connected headphone while doing digi mode via local RX output.

Anyway, a mute function MUST work regardless. I've been developing my own fork for some time, so don't mind but muting audio is a basic functionality that means just one thing. I'll do it myself.

73

dl1ycf commented 2 weeks ago

I have made this more clear in the manual now. But the behaviour is as I said: only auto to the radio is affected. If the radio has no codec then these mute commands have no effect.

dl1ycf commented 2 weeks ago

I totally disagree on your view of the MUTE function. If it is equivalent to moving the AF level slider to the left no one needs it. The intended use is to mute built-in radio speakers while doing digi mode.

mcogoni commented 2 weeks ago

The mute button exists in every audio appliance, from tvs to radios and hifi amplifiers, in order to quickly and temporarily silence the sound. You don't want to use the AF volume because you don't want to lose your set volume and it'd be slower anyway. Especially when you have two receivers it's extremely useful to alternately mute the channels.

dl1ycf commented 2 weeks ago

You can set the AF slider to zero, it will only affect the active receiver. The current behaviour is exactly as I want it to have, whether you like it or not.