search

dl5di / OpenDV

Open Digital Voice software for Amateur Radio based on Jonathan Naylor's (G4KLX) "ircDDBGateway" and "PCRepeaterController" for D-Star
GNU General Public License v2.0
106 stars 63 forks source link

AMBEServer overly dependant #157

Open coolacid opened 6 years ago

coolacid commented 6 years ago

It appears the AMBEServer package has a dependency on opendv-base. I don't believe this is the case?

Seems to run fine with just the binary and no other requirements.

https://github.com/dl5di/OpenDV/blob/master/DummyRepeater/debian/control#L19

johnhays commented 6 years ago

That is correct.

On Jan 25, 2018 20:22, "Jason Kendall" notifications@github.com wrote:

It appears the AMBEServer package has a dependency on opendv-base. I don't believe this is the case?

Seems to run fine with just the binary and no other requirements.

https://github.com/dl5di/OpenDV/blob/master/DummyRepeater/debian/control# L19

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dl5di/OpenDV/issues/157, or mute the thread https://github.com/notifications/unsubscribe-auth/AGP0ekfysv3lFxQD3ewbHdUEtmsgLucoks5tOVMYgaJpZM4Rt2Cg .

mcdermj commented 6 years ago

My recollection is that opendv-base is necessary to create the opendv user that the daemon runs as if you use the included systemd unit file. This potentially could be structured differently but I believe the Debian packaging guidelines frown on creating the same system user in more than one package, which is why the dependencies are structured that way.

— Anna

On Jan 25, 2018, at 8:46 PM, John Hays (K7VE) notifications@github.com wrote:

That is correct.

On Jan 25, 2018 20:22, "Jason Kendall" notifications@github.com wrote:

It appears the AMBEServer package has a dependency on opendv-base. I don't believe this is the case?

Seems to run fine with just the binary and no other requirements.

https://github.com/dl5di/OpenDV/blob/master/DummyRepeater/debian/control# L19

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dl5di/OpenDV/issues/157, or mute the thread https://github.com/notifications/unsubscribe-auth/AGP0ekfysv3lFxQD3ewbHdUEtmsgLucoks5tOVMYgaJpZM4Rt2Cg .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

coolacid commented 6 years ago

Ah, that makes it complicated.

Not being a debian maintainer, and never requesting things upstream I've not hit that issue yet.

Would the postinstal add use having a check to see if the user exists already check make sense? Add this check to both packages? This would ensure the user is created no matter if one, or both packages are installed. Would also remove the dependency that doesn't really exist.