This commit solves the issue https://github.com/dl5di/OpenDV/issues/47

[F4FXL]

It all starts in the DPlusHandler constructor wher eband char is added to m_callsign. If m_callssign is smaller than LONG_CALLSIGN_LENGTH the band char gets added "somewhere" (overrun ?) SetChar does not complain about a char being set outside the string boundaries. In the end when the DPlushandler gets deleted its internal members gets deleted also and we get an error from wxString destructor about freeing the wrong size. What I did to solve the issue :

• Make use of wxString::Clone to set the members. This makes a deep copy of wxString, thus ensuring more thread safety.
• Add withespaces to m_callsign and then truncate it to correct length
• set the band char

[g4klx]

Could you use the resize method on wxString instead of Append and Truncate, it's cleaner. I like the change, does it need applying to DCS and DExtra also?

[F4FXL]

Hi Jonathan,

I will amend to use Resize.
I did not check DCS and DExtra as they both were working fine. Will have a look at it this evening.

I also noticed that m_header gets delted even if there is nothing to delete (if pointer is null)

[F4FXL]

Changed to resize... Will check Dextra and DCS this evenning

[F4FXL]

I made some changes to DExtra and DCS in the same manner.