dl5di / OpenDV

Open Digital Voice software for Amateur Radio based on Jonathan Naylor's (G4KLX) "ircDDBGateway" and "PCRepeaterController" for D-Star
GNU General Public License v2.0
106 stars 63 forks source link

Add URI device as a controller option in DStarRepeater #52

Closed rbrtio closed 8 years ago

rbrtio commented 8 years ago

These changes add the ability to use a DMK Engineering URI device as a controller to trigger the PTT on the attached radio for the DStarRepeater application.

SpudGunMan commented 8 years ago

could you also implement this on the analog repeater code, since you have it all handy

rbrtio commented 8 years ago

Sure, I would rather do it as two separate requests though.

I have tested this in simplex mode this evening and it works like a champ!

SpudGunMan commented 8 years ago

awesome. for sure.. just thought since you have the hardware and the recent code handy might as well fix this everywhere.

F4FXL commented 8 years ago

Hi,

It seems you did not include your work into the VS2008 project. BTW where did you get HID.h ? I downloaded the latest Windows Driver Kit from MS and it seems HID.h has been superseeded by hidsid.h ...

SpudGunMan commented 8 years ago

a lot of us dont use VS to code with, could you retroactively add it to your project files to maintain those that do?

rbrtio commented 8 years ago

Hello,

I don't use VS2008, I just used a text editor. I will need some assistance from someone familiar with VS to get that done.

HID.h was already included in the repository, it wasn't added by me. :-)

F4FXL commented 8 years ago

Hi,

I must be stupid but I was unable to locate HID.h it in the repository. How did you compile it under windows ? Currently, I am in the process of upgrading the DStarRepeater to VS2015. Maybe I'll be able to push something this evening. I will try to include your work.

Geoffrey F4FXL

rbrtio commented 8 years ago

I did not compile it under Windows. The URI has issues under windows by which the volume adjustments get changed based on input to the GPIO pins, so from browsing through the list archives people are not using it on windows.

F4FXL commented 8 years ago

Ok.... I wish I could have read your comment before, I already added your work in my upgrade :)

F4FXL commented 8 years ago

VS2015 pull request https://github.com/dl5di/OpenDV/pull/53

SpudGunMan commented 8 years ago

Well it's not horrible to have it - to compile is still ok we might fix the problem noted some day - it won't hurt the compile since the hang up seems to be the HiD issue for this and other items correct?

rbrtio commented 8 years ago

I agree, as long as other functionality isn't impacted by including it, I don't see the harm.

F4FXL commented 8 years ago

It's included in VS2015, I do not have VS2008 to include it there ....