search

dl9rdz / rdz_ttgo_sonde

270 stars 94 forks source link

Selectable LiveMap themes plus multi-sonde support #258

Closed eben80 closed 2 years ago

eben80 commented 2 years ago

Clicking on the map icon steps through the 3 different map tile options: Light, Dark and ESRI(Satellite) Also includes multi-sonde handling from @cixio This code is also ready to read the persistent theme choice, if it exists and currently ignores the system preference

cixio commented 2 years ago

Please do not merge my changes for multisonde without testing! As far as I can remember there is actually no function to remove old sondes from the map, they will be kept in web storage forever and will always reappear until manually removing them from the browsers web storage.

eben80 commented 2 years ago

Hi, From what I can see the sonde data is stored in session storage which clears when the browser session ends. You can see it in the simulator. The theme is stored in the local storage which persists.

But of course it would be great if someone else can check it too.

On Sun, 12 Dec 2021 at 19:59, cixio @.***> wrote:

Please do not merge my changes for multisonde without testing! As far as I can remember there is actually no function to remove old sondes from the map, they will be kept in web storage forever and will always reappear until manually removing them from the browsers web storage.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dl9rdz/rdz_ttgo_sonde/pull/258#issuecomment-991952011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATNONDYIER2AFQT36MZZBDUQTWKRANCNFSM5J3RCAKQ .

dl9rdz commented 2 years ago

Did not test it extensively, but seems fine, thank you!