dlab-berkeley / R-Data-Visualization-Legacy

D-Lab's 3 hour introduction to data visualization with R. Learn how to create histograms, bar plots, box plots, scatter plots, compound figures, and more using ggplot2 and cowplot.
28 stars 20 forks source link

PR for Native Pipes #27

Closed asteves closed 2 years ago

asteves commented 2 years ago

This PR replaces magrittr based pipes %>% with R's new native pipe |>. No functionality is affected by this change other than pipe replacement.

The PR also closes #25

pssachdeva commented 2 years ago

Will the new pipe only work if someone has updated to the most recent version of R?

asteves commented 2 years ago

Yes, they have to be on R 4.1 or higher for the native pipe to work.

pssachdeva commented 2 years ago

I am not sure how fast adoption of newer R versions happens. Should we hold off on these merges to give people time to update their R versions?

asteves commented 2 years ago

I think we can certainly hold off for this one for next week. Most people practically probably don't update their R on their own. The place where I think this adoption can happen now is R-Fundamentals because people are just starting for the first time.

I would think that these merges should come before next year, maybe before the summer?