search

dlamotte / django-tagging

Automatically exported from code.google.com/p/django-tagging
Other
0 stars 0 forks source link

validator_list no longer exists, breaks tagging in latest SVN #156

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Just updated to the latest SVN of Django where validator_list is removed which 
breaks django-
tagging.
http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#Removedoldformsv
alidatorsa
ndrelatedcode

TypeError: __init__() got an unexpected keyword argument 'validator_list'

I'm quite new to Django so I don't really know how to fix this and how to 
convert it to the new style.

Original issue reported on code.google.com by don...@gmail.com on 27 Aug 2008 at 7:52

GoogleCodeExporter commented 8 years ago 
I svnupped django-trunk a few minutes ago and got the same problem. Donnex, it 
works
(as in no 500/debug page) after commenting out the validation bits, see patch.

Original comment by hanne....@gmail.com on 27 Aug 2008 at 9:36

Attachments:

GoogleCodeExporter commented 8 years ago 
Here is more extensive patch to fix all of tagging.

Original comment by bros...@gmail.com on 27 Aug 2008 at 10:44

Attachments:

GoogleCodeExporter commented 8 years ago 
If people can bang on my patch I can improve it where needed.

Original comment by bros...@gmail.com on 27 Aug 2008 at 10:45

GoogleCodeExporter commented 8 years ago 
i get some import problems

specially in models.py

from tagging import settings

and 

from tagging.validators import isTag that is not used anymore i think

Original comment by lauber.p...@gmail.com on 27 Aug 2008 at 1:17

GoogleCodeExporter commented 8 years ago 
Indeed. Thanks for catching that lauber.patrick. Here is a corrected version.

Original comment by bros...@gmail.com on 27 Aug 2008 at 3:15

Attachments:

GoogleCodeExporter commented 8 years ago 
Missing a Tag  import, updated brosner's patch.

Original comment by ingenier...@gmail.com on 27 Aug 2008 at 5:27

Attachments:

GoogleCodeExporter commented 8 years ago 
When do you think django-tagging(svn) will support "New Django"?

Original comment by dariusz....@gmail.com on 27 Aug 2008 at 9:11

GoogleCodeExporter commented 8 years ago 
I am reviewing the two latest patches and merging the newforms-admin branch 
back to
trunk. the project should be up to date sometime later this evening (work 
permitting).

Original comment by doug.nap...@gmail.com on 27 Aug 2008 at 9:32

GoogleCodeExporter commented 8 years ago

Original comment by doug.nap...@gmail.com on 27 Aug 2008 at 9:32

GoogleCodeExporter commented 8 years ago 
just wanna thank you guys for the work!  that was some fast patching.

Original comment by joe.vasquez on 28 Aug 2008 at 1:02

GoogleCodeExporter commented 8 years ago 
Updated ingenieroariel's patch. It was slightly incomplete. Thanks for catching 
the missing import though.

Original comment by bros...@gmail.com on 28 Aug 2008 at 1:59

Attachments:

GoogleCodeExporter commented 8 years ago 
Could you help me with applying this patch, guys? 
I'm trying this: "patch -p0 <path/to/difffile" in tagging-trunk directory, but 
patch
command complains about wrong -p and asks me exact name of file to patch...

Original comment by sergo.po...@gmail.com on 28 Aug 2008 at 8:31

GoogleCodeExporter commented 8 years ago 
sergo - make sure you are in the 'tagging' directory, instead of the svn root.

Original comment by mono...@gmail.com on 28 Aug 2008 at 9:21

GoogleCodeExporter commented 8 years ago 
r148 [newforms-admin] and r149 [trunk] fix this.

Original comment by doug.nap...@gmail.com on 29 Aug 2008 at 5:05