search

dlandon / unassigned.devices

Unassigned Devices plugin for unRAID
Other
81 stars 39 forks source link

Change popups from jQuery UI to SweetAlert2 #50

Closed gfjardim closed 4 years ago

gfjardim commented 4 years ago

Dan, in this PR I just overlaid some of the original functions. If you decide to commit this, I'll make some code cleaning.

dlandon commented 4 years ago

I like it. Just needs some adjustment of the input lines.

gfjardim commented 4 years ago

You mean input fields or the text itself?

dlandon commented 4 years ago

Both. Too far left. ALso the format button does not work.

gfjardim commented 4 years ago

please send a screenshot to me.

dlandon commented 4 years ago

I've broken something. I can't get the pop ups now.

gfjardim commented 4 years ago

Ok, found the bug about on input types being too far left, this is caused by current Preclear that includes an older version of the swal2 css file. Just updated the plugin.

dlandon commented 4 years ago

Would that prevent the buttons from working? They started off working, and now don't work. Remember me telling you some time ago about the files you commit having cr, lf and not just lf? I have to edit them and remove the cr. Very strange.

dlandon commented 4 years ago

Ok. Just found out on my end with preclear installed the buttons work. When it is removed, the buttons don't work.

gfjardim commented 4 years ago

The swal2 plugin is loaded on line 1030 of UnassignedDevices.page.

gfjardim commented 4 years ago

Found it, committed a PR.