Add formatUnicorn prototype function

dlandon / unassigned.devices

Unassigned Devices plugin for unRAID

Other

81 stars 39 forks source link

Add formatUnicorn prototype function #51

Closed gfjardim closed 4 years ago

dlandon commented 4 years ago

Looks good. Once you finish your clean up I'll commit it.

Any issues with the different themes?
Any compatibility issues with earlier versions of Unraid?

dlandon commented 4 years ago

I notice that chrome wants to autofill the username and password with the Unraid root credentials. Can we stop that?

gfjardim commented 4 years ago

1) nope, just some buttons styling differently, but I've already fixed it. 2) I don't think so. Maybe we get some CSS errors in the future when SweetAlert2 gets integrated into core Unraid. Since it's an UI enhancement, I don't see how it could be incompatible with older versions of Unraid. 3) Just took care of the autofill weirdness.

dlandon commented 4 years ago

Thanks. Once you commit your chanes, I'm going to do some work on removing some backwards compatibility. Supporting back to 6.4 is in my mind too far back.