Better Preclear Plugin integration

dlandon / unassigned.devices

Unassigned Devices plugin for unRAID

Other

81 stars 39 forks source link

Better Preclear Plugin integration #6

Closed gfjardim closed 7 years ago

gfjardim commented 7 years ago

Now, it’s possible to start/stop preclear jobs from Unassigned Devices directly.

dlandon commented 7 years ago

Your files had carriage return/line feed endings. The .page file caused an error in unRAID. It's fixed and I'll test a bit and then release.

dlandon commented 7 years ago

Should preclear be disabled when destructive mode is disabled? With destructive mode off, you can preclear a disk but not format a disk or remove a partition. That might cause some confusion.

gfjardim commented 7 years ago

Very strange. All my files have Unix line endings because I'm coding in MacOS. Something got messy in GH...

About disabling preclear, I'm not sure how to treat destructive mode, but I think it's pretty safe to let it enabled either way. If a user have the preclear script, it's presumable he know what he's doing.