dlandon / unassigned.devices

Unassigned Devices plugin for unRAID
Other
81 stars 39 forks source link

Allow $ character to be used in remote SMB share names #62

Closed ksarnelli closed 3 years ago

ksarnelli commented 3 years ago

This will allow Unassigned Devices to mount remote hidden Windows Shares (shares that end in a $).

This PR will likely prevent other unexpected issues by preventing parse_ini_file() from trying to process INI values instead of sending the raw data back.

dlandon commented 3 years ago

This approach is too brute force for my liking, and I feel compelled to do a thorough test of UD to confirm there are no other issues from this PR. I don't have the time right now to do that kind of testing and then release it and have support issues. I do not work for Limetech and work on UD in my spare time. That's why I am careful about responding to every enhancement request. Those enhancements that are appropriate to a wider audience, I will consider.