search

dlandon / unassigned.devices

Unassigned Devices plugin for unRAID
Other
85 stars 40 forks source link

Add a field where the user can set additional mount options #74

Closed bavis-m closed 3 years ago

bavis-m commented 3 years ago

Adds a field to EditSettings.page where the user can add options to the mount command. Useful for stuff like filesystem tuning (setting w/r/bsize for cifs, for example)

This PR also includes PR #73

dlandon commented 3 years ago

I'm not a fan of this idea. It looks like it just opens me up to additional support when a user doesn't know what they are doing.

bavis-m commented 3 years ago

Could it perhaps be behind an Advanced flag or something? Changing the network read size for me can give me up to 8x read performance transferring large files on cifs over WAN. I know I can just write a script to mount it manually, but the tool is helpful to easily see which mounts I have active, automounted, etc.

dlandon commented 3 years ago

What did you find was the best read size?

bavis-m commented 3 years ago

I use rsize=8388608,wsize=8388608,bsize=16777216. These are the max supported by my smbd, but not every implementation will support values this large (and on a LAN I'm not sure if these values are counterproductive).

On Wed, Nov 3, 2021 at 2:05 PM dlandon @.***> wrote:

What did you find was the best read size?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dlandon/unassigned.devices/pull/74#issuecomment-960064606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXE2KNF6ZPQJPQMTC32A7TUKGWZVANCNFSM5HJRY4LQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bavis-m commented 3 years ago

Oh, I forgot, adding vers=3.1.1 gets more speed as well.

On Wed, Nov 3, 2021 at 2:24 PM Mark Bavis @.***> wrote:

I use rsize=8388608,wsize=8388608,bsize=16777216. These are the max supported by my smbd, but not every implementation will support values this large (and on a LAN I'm not sure if these values are counterproductive).

On Wed, Nov 3, 2021 at 2:05 PM dlandon @.***> wrote:

What did you find was the best read size?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dlandon/unassigned.devices/pull/74#issuecomment-960064606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXE2KNF6ZPQJPQMTC32A7TUKGWZVANCNFSM5HJRY4LQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dlandon commented 3 years ago

I've changed the vers mount option to 3.1.1.

Dan Landon

------ Original Message ------ From: "bavis-m" @.> To: "dlandon/unassigned.devices" @.> Cc: "dlandon" @.>; "Comment" @.> Sent: 11/3/2021 4:53:18 PM Subject: Re: [dlandon/unassigned.devices] Add a field where the user can set additional mount options (PR #74)

Oh, I forgot, adding vers=3.1.1 gets more speed as well.

On Wed, Nov 3, 2021 at 2:24 PM Mark Bavis @.***> wrote:

I use rsize=8388608,wsize=8388608,bsize=16777216. These are the max supported by my smbd, but not every implementation will support values this large (and on a LAN I'm not sure if these values are counterproductive).

On Wed, Nov 3, 2021 at 2:05 PM dlandon @.***> wrote:

What did you find was the best read size?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://github.com/dlandon/unassigned.devices/pull/74#issuecomment-960064606, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ABXE2KNF6ZPQJPQMTC32A7TUKGWZVANCNFSM5HJRY4LQ . Triage notifications on the go with GitHub Mobile for iOS

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dlandon/unassigned.devices/pull/74#issuecomment-960165875, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKCMFXJ2I5GQYUTEJ77MVLUKGVM5ANCNFSM5HJRY4LQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dlandon commented 3 years ago

I'm not wanting to implement this. I've already changed the vers to 3.1.1 and the read and write options I'll have to consider further.