dlandon / unassigned.devices

Unassigned Devices plugin for unRAID
Other
81 stars 39 forks source link

【Feature】Add seal option for smb shares #98

Closed babatonga closed 7 months ago

babatonga commented 7 months ago

I propose adding a setting to enable the 'seal' option for remote SMB(3) shares, enhancing privacy and security.

Details:

Benefits:

image

dlandon commented 7 months ago

I will research this.

dlandon commented 7 months ago

This is what I've found out so far: The 'seal' option, which enables SMB3 transport encryption when mounting a CIFS share, comes with certain considerations:

It's essential to weigh the benefits of enhanced security against these potential downsides. In situations where data security is a top priority, enabling encryption might be a reasonable trade-off. However, in environments where performance is critical and the network is considered secure, you may choose not to use the 'seal' option.

If I decide to do this, it would have to be a setting in UD Settings to enable/disable. I don't like adding too many configuration options because it can jus confuse users. I am also concerned about performance issues.

What is your use case? Why do you feel this is necessary on a local LAN?

babatonga commented 7 months ago

In a local LAN, this might not be necessary, but I am connecting a Storage Box from Hetzner over the Internet: https://docs.hetzner.com/robot/storage-box/access/access-samba-cifs/

The documentation recommends using the 'seal' option for encrypting SMB traffic.

So, having an option that defaults to false seems like a good idea, I believe. There could be a note indicating that this works only with SMB3 servers that support it and may not be necessary in a local LAN.

Alternatively, it would be great if unassigned.devices supports SSHFS for such purposes. But that would probably be another feature request and might require additional dependencies (such as sshfs).

dlandon commented 7 months ago

I'm adding a configuration to the Device Settings for SMB remote shares to set encryption by device: Screenshot 2024-01-13 135518

dlandon commented 7 months ago

This will be in the next release of UD.