search

dlang-bots / mention-bot

Automatically mention potential reviewers on pull requests.
Other
1 stars 1 forks source link

Use hard-coded teams #12

Closed wilzbach closed 8 years ago

wilzbach commented 8 years ago

An even quicker and dirtier solution is just to keep a whitelist with the members of "Team Phobos".

PR for the quick fix idea by @klickverbot

CC @MartinNowak @schveiguy @burner

I think in the following weeks we should decide whether dlang-bot is worth keeping and then implement it in D, which I would prefer to hack with. However I tested it locally with three PRs and it seems to work :)

I quickly created this whitelist table and I am pretty sure I missed someone (?). In any case with the Heroku auto-deploy this white-list table can even be edited from the web ;-)

Btw this should fix all open issues (#7, #10, #11) for the time being.

dnadlinger commented 8 years ago

There is a couple of missing people, but I'm merging this now because the wrong "you've been assigned" messages are getting annoying.

@wilzbach: You should be able to view a list of members for all of the teams here. Of course, not all of them might be active, but erring on the side of being more inclusive might be wise.

dnadlinger commented 8 years ago

Hmm, I guess it makes sense to ignore inactive people, although I wish we could automate that (scrap the commit log once every week or so?).

wilzbach commented 8 years ago

you can add my name to it as well

@burner Sorry lost track of it.- > #14

There is a couple of missing people, but I'm merging this now because the wrong "you've been assigned" messages are getting annoying.

Oh I felt the same. I actually wanted to turn the bot (temporarily) off today.

@wilzbach: You should be able to view a list of members for all of the teams here. Of course, not all of them might be active, but erring on the side of being more inclusive might be wise.

14 should include a more complete list.

For the tools repo I went through the commits list and looked at merge commits in the last two years.

Hmm, I guess it makes sense to ignore inactive people, although I wish we could automate that (scrap the commit log once every week or so?).

I wish so too, but unfortunately I won't get to that in the next two weeks & it might get tricky, because there are some people that only merge stuff once in a while (e.g. druntime, dlang.org or tools) and thus could be filtered out.