search

dlang-bots / mention-bot

Automatically mention potential reviewers on pull requests.
Other
1 stars 1 forks source link

Blacklist braddr #6

Closed wilzbach closed 8 years ago

wilzbach commented 8 years ago

@braddr seems to have touched literally every file in DMD and Phobos and thus be included in most pings.

MartinNowak commented 8 years ago

Should we use a .mention-bot file instead?

wilzbach commented 8 years ago

Should we use a .mention-bot file instead?

The .mention-bot is per repository, so it allows further customization, which I think we don't need for now?

wilzbach commented 8 years ago

The .mention-bot is per repository, so it allows further customization, which I think we don't need for now?

I was trying to say that for now we are better off of we don't need to merge files into the official repositories.

braddr commented 8 years ago

Certainly a quick way of handling this, but really, probably not the best. There should likely be a time based element to who's mentioned.

wilzbach commented 8 years ago

Certainly a quick way of handling this, but really, probably not the best. There should likely be a time based element to who's mentioned.

@braddr at the moment we are just experimenting whether pinging based on the diff is helpful. If it turns out to do so, we will do it properly in D, but for now just toggling some options in the Javascript tool is faster.

MartinNowak commented 8 years ago

Certainly a quick way of handling this, but really, probably not the best. There should likely be a time based element to who's mentioned.

Yes, it's already obvious that this is a problem with mention-bot.

vjeux commented 8 years ago

FYI, we implemented a time based to mention-bot for all fb projects (implemented in Hack) and it gave dramatically better results for people that used to work on the codebase but moved on to other projects.

The formula is really simple: for each line of code that is blamed, instead of adding 1, add a linear interpolation where now is 360 and 8 months in the past (or more) is 0.

I'd love to make that the default on the open source mention-bot project (in JavaScript), if you fancy implementing it and sending a pull request over there, I would appreciate :)

cc @mkonicek